Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Liberland #1414

Merged
merged 1,463 commits into from
May 22, 2024

Xor commission fix

a38e306
Select commit
Loading
Failed to load commit list.
Merged

Enable Liberland #1414

Xor commission fix
a38e306
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Soramitsu-Sonar-PR-decoration / polkaswap-exchange-web Sonarqube Results failed Dec 12, 2023 in 1m 1s

Quality Gate failed

Failed

  • D Reliability Rating on New Code (is worse than A)
  • 0.00% Coverage on New Code (is less than 80.00%)
  • 6.56% Duplicated Lines (%) on New Code (is greater than 3.00%)

Analysis Details

28 Issues

  • Bug 10 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 18 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 6.56% Duplicated Code (1.30% Estimated after merge)

Project ID: jp.co.soramitsu:polkaswap-exchange-web

View in SonarQube

Annotations

Check warning on line 1 in src/store/staking/getters.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/getters.ts#L1 

Remove this unused import of 'FPNumber'.

Check failure on line 242 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L242 

Refactor this redundant 'await' on a non-promise.

Check failure on line 284 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L284 

Refactor this redundant 'await' on a non-promise.

Check failure on line 156 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L156 

Refactor this redundant 'await' on a non-promise.

Check warning on line 12 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L12 

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 30 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L30 

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check failure on line 130 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L130 

Refactor this redundant 'await' on a non-promise.

Check failure on line 221 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L221 

Refactor this redundant 'await' on a non-promise.

Check failure on line 146 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L146 

Refactor this redundant 'await' on a non-promise.

Check failure on line 200 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L200 

Refactor this redundant 'await' on a non-promise.

Check failure on line 138 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L138 

Refactor this redundant 'await' on a non-promise.

Check failure on line 263 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L263 

Refactor this redundant 'await' on a non-promise.

Check failure on line 177 in src/store/staking/actions.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/store/staking/actions.ts#L177 

Refactor this redundant 'await' on a non-promise.

Check warning on line 158 in src/modules/staking/demeter/components/StakeDialog.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/demeter/components/StakeDialog.vue#L158 

Extract this nested ternary operation into an independent statement.

Check warning on line 390 in src/modules/staking/sora/views/Overview.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/views/Overview.vue#L390 

Unexpected missing generic font family

Check warning on line 106 in src/modules/staking/sora/components/ValidatorsDialog.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorsDialog.vue#L106 

Extract this nested ternary operation into an independent statement.

Check warning on line 112 in src/modules/staking/sora/components/ValidatorsDialog.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorsDialog.vue#L112 

Extract this nested ternary operation into an independent statement.

Check warning on line 239 in src/modules/staking/sora/components/ValidatorsList.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorsList.vue#L239 

Unexpected missing generic font family

Check warning on line 323 in src/modules/staking/sora/components/ValidatorsList.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorsList.vue#L323 

Unexpected missing generic font family

Check warning on line 86 in src/modules/staking/sora/components/ValidatorsAttentionDialog.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorsAttentionDialog.vue#L86 

Unexpected missing generic font family

Check warning on line 101 in src/modules/staking/sora/components/ValidatorsFilterDialog.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorsFilterDialog.vue#L101 

Unexpected duplicate "margin-bottom"

Check warning on line 3 in src/modules/staking/sora/components/ValidatorAvatar.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/ValidatorAvatar.vue#L3 

Add an "alt" attribute to this image.

Check failure on line 261 in src/modules/staking/sora/components/PendingRewardsDialog.vue

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/components/PendingRewardsDialog.vue#L261 

Unexpected shorthand "margin" after "margin-top"

Check warning on line 99 in src/modules/staking/sora/mixins/StakingMixin.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/mixins/StakingMixin.ts#L99 

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.

Check warning on line 111 in src/modules/staking/sora/mixins/StakingMixin.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / polkaswap-exchange-web Sonarqube Results

src/modules/staking/sora/mixins/StakingMixin.ts#L111 

Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator.
View more details on Soramitsu-Sonar-PR-decoration