Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/error localstorage override #1474

Merged
merged 16 commits into from
Jul 23, 2024
Merged

Fix/error localstorage override #1474

merged 16 commits into from
Jul 23, 2024

Conversation

Kron1749
Copy link
Contributor

@Kron1749 Kron1749 commented Jul 22, 2024 •
edited
Loading

Task

[PW-1210]: Error when Localstorage is overloaded.

Changes

Description.
[PW-1210]: https://soramitsu.atlassian.net/browse/PW-1210

  1. Added EventBus to track if smth was added to local storage
  2. Added localStorageInterceptor.ts for emitting events by EventBus if item was added to local storage
  3. Added clearLocalStorage function in App.vue to clear in local storage the history and assetsAddresses
  4. Added BrowserNotificationLocalStorageOverride.vue to display local storage error

Nikita-Polyakov
Nikita-Polyakov requested changes Jul 22, 2024
View reviewed changes
src/lang/en.json Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/utils/localStorageInterceptor.ts Outdated Show resolved Hide resolved
Nikita-Polyakov
Nikita-Polyakov reviewed Jul 22, 2024
View reviewed changes
src/App.vue Outdated Show resolved Hide resolved
@Kron1749 Kron1749 merged commit 38aeeb0 into develop Jul 23, 2024
1 of 2 checks passed
@Kron1749 Kron1749 deleted the fix/error-localstorage-override branch July 23, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikita-Polyakov Nikita-Polyakov Nikita-Polyakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kron1749 @Nikita-Polyakov