Feature/new swap transfer batch #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefashkaa
reviewed
Mar 2, 2023
| } | ||
|
|
||
| get xorBalance() { | ||
| const asset = this.accountAssets.find((item) => item.address === XOR.address); |
There was a problem hiding this comment.
need to check it, cuz we might already have XOR getter
stefashkaa
reviewed
Mar 2, 2023
| } | ||
|
|
||
| get xorFeeRequired() { | ||
| return this.xorFeeAmount * 1.05 - this.xorBalance; |
There was a problem hiding this comment.
it's better to use FPNumber (and all methods like sub) instead of JS numbers for all calculations
stefashkaa
reviewed
Mar 2, 2023
| return this.xorFeeAmount * 1.05 - this.xorBalance; | ||
| } | ||
|
|
||
| get showXorRequiredField() { |
stefashkaa
reviewed
Mar 2, 2023
| @@ -206,6 +291,10 @@ export default class ReviewDetails extends Mixins(mixins.TransactionMixin) { | |||
| return getAssetBalance(asset); | |||
| } | |||
|
|
|||
| get xor() { | |||
There was a problem hiding this comment.
This is for access XOR from template
stefashkaa
reviewed
Mar 2, 2023
| } | ||
|
|
||
| get networkSwapFee(): number { | ||
| return FPNumber.fromCodecValue(this.networkFees[Operation.Swap]).toNumber() * 2; |
There was a problem hiding this comment.
This is preset value in swap dialog, if you don't have enough XOR for tx taxes.
0,7 XOR - tax for transfer, and 0,7 XOR - tax for swap operation to required XOR amount
stefashkaa
reviewed
Mar 2, 2023
src/store/routeAssets/actions.ts
Outdated
| const time = Date.now(); | ||
| await api | ||
| .submitExtrinsic( | ||
| (api.api.tx.liquidityProxy as any).swapTransferBatch(groupedData, ...params.args), |
stefashkaa
reviewed
Mar 2, 2023
src/App.vue
Outdated
| @@ -390,7 +390,7 @@ export default class App extends Mixins(mixins.TransactionMixin, NodeErrorMixin) | |||
| status: RecipientStatus.FAILED, | |||
| }); | |||
| }); | |||
| } else if (value.status === TransactionStatus.InBlock || isNewTx) { | |||
| } else if (value.status === TransactionStatus.Finalized) { | |||
There was a problem hiding this comment.
need to check it, cuz TXs will be parsed slower than it actually is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
New swap transfer batch
Changes
New swap transfer batch implementation and small fixes