Skip to content

Commit

Permalink
cluster: make DefaultSyncTimeout infinite.
Browse files Browse the repository at this point in the history
SyncTimeout is currently undocumented and is set to 30 minutes causing
unexpected behaviors to users.

So make its default set to 0 (infinite).

Another PR will document it.
  • Loading branch information
sgotti committed Jan 21, 2020
1 parent 2ae5e0f commit d6617c9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/cluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const (
DefaultRequestTimeout = 10 * time.Second
DefaultConvergenceTimeout = 30 * time.Second
DefaultInitTimeout = 5 * time.Minute
DefaultSyncTimeout = 30 * time.Minute
DefaultSyncTimeout = 0
DefaultFailInterval = 20 * time.Second
DefaultDeadKeeperRemovalInterval = 48 * time.Hour
DefaultMaxStandbys uint16 = 20
Expand Down

0 comments on commit d6617c9

Please sign in to comment.