*: add support for etcd v3 api #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
force-pushed
the
etcd_api_v3
branch
3 times, most recently
from
6cf0ec4 to
c4540ad
Compare
This was referenced Dec 24, 2017
Closed
sgotti
force-pushed
the
etcd_api_v3
branch
4 times, most recently
from
627b88b to
76d0189
Compare
update etcd and include clientv3 and related dependencies
sgotti
force-pushed
the
etcd_api_v3
branch
2 times, most recently
from
7d018ab to
ee4e8c7
Compare
for etcdv2 and consul we keep using libkv while for etcd v3 api we'll directly use the etcdclientv3. We abstract the implementation under a KVStore and an Election interface. We haven't implemented a libkv store for etcdv3 since libkv looks quite dead and doesn't support the context package. So in future we'll probably move out from libkv to better use context features.
Update doc for etcdv3 backend. Update examples to use etcdv3 instead of etcd (aka etcdv2) api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For etcdv2 and consul we keep using libkv while for etcd v3 api we'll directly
use the etcdclientv3. We abstract the implementation under a KVStore and an
Election interface. We haven't implemented a libkv store for etcdv3 since libkv
looks quite dead and doesn't support the context package. So in future we'll
probably move out from libkv to better use context features.
Note: currently semaphore isn't testing with etcdv3 api.