Add Timeout for kubeclient #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshba
force-pushed
the
timeout-for-kubeclient
branch
2 times, most recently
from
6a1770e to
c601d0e
Compare
sgotti
requested changes
Jun 6, 2019
There was a problem hiding this comment.
@dineshba Thanks for your PR. it LGTM.
Looking at the current go client code https://github.com/kubernetes/client-go/blob/cd12199def5832afb81d78426c3b2758ee70110f/rest/request.go#L722 looks like the timeout is internally used to set a context.WithTimeout
dineshba
force-pushed
the
timeout-for-kubeclient
branch
from
c601d0e to
2f4c21c
Compare
sgotti
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding timeout for
kubeclientby adding timeout forrestclientI have made two commits
getKubeValues