-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable store timeout #765
Conversation
@sgotti Can you review the pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snailxr Thanks for the PR. It LGTM. Please rebase and squash in a single commit adding a better commit message, something like:
*: Add configurable store timeout
Add a command line option to set the store timeout.
@snailxr integration tests are failing since the new |
@sgotti Is there a easy way to run the integration tests locally? 😃 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snailxr Integration tests are now successful.
Since a new command line option as been added, also the doc should be regenerated.
You should execute ./scripts/gen_commands_doc.sh
and commit changes to the doc/commands
files.
Add a command line option to set the store timeout.
@sgotti The command documents regenerated |
@snailxr Thanks! Merging. |
No description provided.