Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable store timeout #765

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

snailxr
Copy link

@snailxr snailxr commented Feb 29, 2020

No description provided.

@snailxr
Copy link
Author

snailxr commented Mar 1, 2020

@sgotti Can you review the pull request?

Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snailxr Thanks for the PR. It LGTM. Please rebase and squash in a single commit adding a better commit message, something like:

*: Add configurable store timeout

Add a command line option to set the store timeout.

@snailxr snailxr changed the title Add StoreTimeout config Add configurable store timeout Mar 4, 2020
@sgotti
Copy link
Member

sgotti commented Mar 4, 2020

@snailxr integration tests are failing since the new Store.Config Timeout field introduced in this patch is not set (and will default to 0) when creating the tests stores in https://github.com/sorintlab/stolon/blob/master/tests/integration/utils.go

@snailxr
Copy link
Author

snailxr commented Mar 4, 2020

@sgotti Is there a easy way to run the integration tests locally? 😃

@sgotti
Copy link
Member

sgotti commented Mar 4, 2020

@snailxr

  • Use a local agola and execute a direct run (also change the .agola/config.jsonnet to remove unneeded tasks)

  • test a specific store with INTEGRATION=1 STOLON_TEST_STORE_BACKEND=etcdv3 PARALLEL=5 bash -x ./test. It requires an etcd v3.x binary in your PATH. It'll use your local installed version of postgres.

Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snailxr Integration tests are now successful.

Since a new command line option as been added, also the doc should be regenerated.

You should execute ./scripts/gen_commands_doc.sh and commit changes to the doc/commands files.

Add a command line option to set the store timeout.
@snailxr
Copy link
Author

snailxr commented Mar 8, 2020

@sgotti The command documents regenerated

@sgotti
Copy link
Member

sgotti commented Mar 10, 2020

@snailxr Thanks! Merging.

@sgotti sgotti merged commit f512d7e into sorintlab:master Mar 10, 2020
@sgotti sgotti added this to the v0.17.0 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants