Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add svgSpriteLoaderDirs api to support antd-mobile icon #144

Merged
merged 1 commit into from
Feb 23, 2017
Merged

feat: add svgSpriteLoaderDirs api to support antd-mobile icon #144

merged 1 commit into from
Feb 23, 2017

Conversation

paranoidjk
Copy link
Collaborator

@paranoidjk paranoidjk commented Feb 22, 2017

close #137

ref: ant-design/ant-design-mobile#840

@paranoidjk paranoidjk changed the title feat: add customSvgLoader api to support antd-mobile icon feat: add svgSpriteLoaderDirs api to support antd-mobile icon Feb 22, 2017
@paranoidjk paranoidjk changed the title feat: add svgSpriteLoaderDirs api to support antd-mobile icon [WIP] feat: add svgSpriteLoaderDirs api to support antd-mobile icon Feb 22, 2017
@paranoidjk paranoidjk changed the title [WIP] feat: add svgSpriteLoaderDirs api to support antd-mobile icon feat: add svgSpriteLoaderDirs api to support antd-mobile icon Feb 22, 2017
@paranoidjk
Copy link
Collaborator Author

@sorrycc 本地 test 都是过的,ci 我看了下是之前的用例 pxtorem 挂了,具体看是ci机器上webpack构建出来的代码module顺序与本地有些不同

.gitignore Outdated
@@ -4,6 +4,7 @@ npm-debug.log*
/lib
/.nyc_output
/test/**/dist
/test/**/node_modules
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不要加,test 下是需要测 node_modules 的。

@sorrycc
Copy link
Owner

sorrycc commented Feb 23, 2017

最好是抽象一个简单的场景,而不是安装整个 antd-mobile 的依赖。用例如果不好加的话可以先不要了。

@paranoidjk
Copy link
Collaborator Author

@sorrycc all done. 用例已经简化了

@xiechao1211
Copy link

xiechao1211 commented Feb 23, 2017

请问在.roadhotrc 中配置SVG图标,是否可以稍微详细一点儿?示例代码不是很懂?谢谢。@paranoidjk

@sorrycc sorrycc merged commit a9cb844 into sorrycc:master Feb 23, 2017
@sorrycc
Copy link
Owner

sorrycc commented Feb 23, 2017

👍🏾

@paranoidjk
Copy link
Collaborator Author

@sorrycc 啥时候release新版本?我好更新antd-mobile的文档

@sorrycc
Copy link
Owner

sorrycc commented Feb 24, 2017

bumped 0.6.0-beta1

@xiechao1211
Copy link

使用 npm update roadhot 或者 npm install @RoadHog@0.6.0-beta1 均出错?但是 npm view version roadhog 可以看到0.6.0版本?更新错误提示均是:
npm WARN update-linked node_modules\roadhog needs updating to 0.6.0-beta1 from 0.5.3 but we can't, as it's a symlink
@sorrycc 是不是beta版的不能更新?我使用的是dva-cli已经创建好的目录。谢谢。

@paranoidjk
Copy link
Collaborator Author

@xiechao1211 try rm -rf node_modules && npm i roadhog@0.6.0-beta1 -S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

如何在roadhogrc配置文件中添加新的babel-loader?比如svg-sprite-loader
3 participants