Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to webp for preview thumbnails #372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vankerkom
Copy link
Contributor

WebP is baseline since 2020, it reduces bandwidth by 25% compared to jpg.

WebP is baseline since 2020, it reduces bandwidth by 25% compared to jpg.
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (7238941) to head (82727f5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          14       14           
  Lines        1185     1185           
  Branches      228      228           
=======================================
  Hits         1101     1101           
  Misses         83       83           
  Partials        1        1           
Flag Coverage Δ
unittests 92.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soruly
Copy link
Owner

soruly commented Oct 20, 2024

Not all API users are using it on web browsers, they may be using it on native apps, or with 3rd party services like chat bots which has unknown media format support. So jpg is not a format I'd like to drop. webp is good, but supporting more than one media format makes things complicated. This is also true for video preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants