Implemented array-job-based SLURM integration, deprecated old version #1130
+882
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a lot of problems with the non-array-based SLURM jobs, mainly due to the scheduler not liking thousands of small jobs. This was also brought up by #1028, as well as by the system administrators of Komondor.
This PR adds support for array jobs, and deprecates the old version. Furthermore, it moves resource measurements to a
runexec-based solution by default (as we got access to cgroups).I'm marking this PR as a draft as while the SV-COMP reproduction is ongoing, I expect some minor changes to still occur. However, I think the majority of the implementation work is done, and is therefore reviewable.