Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize #3

Closed
jeanconn opened this issue Jul 13, 2016 · 5 comments
Closed

Vectorize #3

jeanconn opened this issue Jul 13, 2016 · 5 comments

Comments

@jeanconn
Copy link
Contributor

Should Quaternion be updated to use the vector forms in

https://github.com/sot/mica/blob/master/mica/quaternion.py

?

@taldcroft
Copy link
Member

Perhaps, but is there an immediate driver?

@jeanconn
Copy link
Contributor Author

The immediate driver is that if you are updating Quaternion, the two
"branches" are diverging.
On Jul 13, 2016 2:07 PM, "Tom Aldcroft" notifications@github.com wrote:

Perhaps, but is there an immediate driver?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAwT1P5DOBZENZC3N1fiRv-X8GxYVceTks5qVSlmgaJpZM4JLsKp
.

@taldcroft
Copy link
Member

Can you make an actual branch and PR for the vectorized version? I recall having some reservations about the implementation but I don't remember details.

@jeanconn
Copy link
Contributor Author

The actual branch is still there. I'll take an action to clean it up to
largely match mica.quaternion and make a PR.

On Wed, Jul 13, 2016 at 2:22 PM, Tom Aldcroft notifications@github.com
wrote:

Can you make an actual branch and PR for the vectorized version? I recall
having some reservations about the implementation but I don't remember
details.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAwT1Gj4X2jnoYnRLNX-XLcUi9RF0lS8ks5qVSztgaJpZM4JLsKp
.

@jeanconn
Copy link
Contributor Author

Closed by #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants