WIP check for stability for dec near poles #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
commented
Feb 13, 2020
| def _check_dec_for_stability(self, dec): | ||
| if np.any(np.abs(dec) > MAX_DEC_FOR_STABILITY): | ||
| warnings.warn(f'Declination abs(value) > {MAX_DEC_FOR_STABILITY}' | ||
| f', numerical problems possible') |
There was a problem hiding this comment.
Need to supply a stacklevel, and thinking on this now maybe that is why I wasn't seeing a warning when I expected it in some ipython interactive testing. That way the warning shows the context of the user call that generated the warning, except that sometimes it is not a fixed number of stack levels up to the user call. Ugh.
Or maybe better is to put this in a warnings context manager to set the warning filter here to 'always'. That has the downside that it becomes impossible to disable the warning.
|
Not worth the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was my initial approach, but I stopped working after getting some unexpected results and deciding it wasn't that high a priority. For the record this is what I had.
Testing
Fixes #10