Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shiny tests #9

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Shiny tests #9

merged 2 commits into from
Jun 17, 2020

Conversation

taldcroft
Copy link
Member

Description

More test fixes / improvements for shiny. I also default to using bare pytest for testing these days, but this has problems with namespace packages, so I put in an explicit check and comment here to prevent later problems.

Testing

  • Passes unit tests on MacOS in ska3 and ska3-shiny
  • [N/A] Functional testing

@@ -1,3 +1,4 @@
[pytest]
filterwarnings =
ignore:the imp module:DeprecationWarning
ignore:parse functions are required to provide a named argument:PendingDeprecationWarning
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird since it seems like setuptools_scm is triggering its own pending deprecation. Or maybe I'm misunderstanding, but in any case it can be ignored. If it turns into a deprecation warning (no longer pending) then we'll see it again.

@taldcroft taldcroft merged commit 65d0c80 into master Jun 17, 2020
@taldcroft taldcroft deleted the shiny-tests branch June 17, 2020 13:43
@javierggt javierggt mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant