Minor fixes

[javierggt]

Description

This PR introduces some small changes:

• specify "use_supplement=False" when calling agasc.get_star in mag_estimate (Need to include use_supplement=False in supplement processing code #106)
• small changes in error loggging
• specifying argument types (Command line arg types should be specified or coerced during parsing #79)
• setting default values in agasc_stats (Follow-on issue for #83: last obs date 1997:365 #87, Follow-on issue for #83: nan catalog mag #88 )
• stop using the saturated pixel flag to select times (Ignore saturated pixel in supplement processing #93)
• Display the slot number somewhere in the report (Put the image slot somewhere in the detail report page #98)
• fixed an error combining masks (Fix bug in masking #99)
• removed the "mismatch in telemetry between aca_l0 and cheta" exception, which happened when the number of samples from cheta.fetch differed from the number of samples from mica.archive.l0.get_slot_data. Now the times are the intersection of these times by construction. (Followup to the "mismatch in telemetry between aca_l0 and cheta" issue #108)

Testing

• Passes unit tests on MacOS, linux, Windows (at least one required)
• Functional testing:
  • For Ignore saturated pixel in supplement processing #93 and Fix bug in masking #99, I only checked it runs and the magnitude in the end seems reasonable.
  • To check for Command line arg types should be specified or coerced during parsing #79, run this and verify the resulting supplement

    python -m agasc.scripts.update_supplement --obsid 46686 --agasc-id=175379112 --status=bad --comments="ACA high background event" --log-level=debug
    

  • To check for Follow-on issue for #83: last obs date 1997:365 #87 Follow-on issue for #83: nan catalog mag #88, and Put the image slot somewhere in the detail report page #98

    export AGASC_DIR=`pwd`
    cp ~/SAO/ska/data/agasc/* .
    echo 505545160 > agasc_id
    echo 991559968 >> agasc_id
    agasc-update-magnitudes --agasc-id-file agasc_id --log-level debug --report
    open supplement_reports/weekly/latest/index.html
    # check that mag_aca and last_obs are set, check that the slot is shown in star report
    

  • To check for Followup to the "mismatch in telemetry between aca_l0 and cheta" issue #108

    export AGASC_DIR=`pwd`
    cp ~/SAO/ska/data/agasc/* .
    agasc-update-magnitudes --agasc-id-file suspect_agasc_id --log-level debug --report
    open supplement_reports/weekly/latest/index.html
    # check that a bunch of stars succeded now. The only failures are the ones where all OBS were suspect.
    

open supplement_reports/weekly/latest/index.html
Fixes #79
Fixes #87
Fixes #88
Fixes #93
Fixes #98
Fixes #99
Fixes #106
Fixes #108

[taldcroft]

Should this have use_supplement=False? Otherwise the MAG_ACA below will be from the supplement if available.

[jeanconn]

I thought we'd captured that as a separate issue but I guess I forgot to do so.

[taldcroft]

This is now #106

[taldcroft]

I looked through each commit and they all look reasonable. Thanks for the atomic commits and helpful commit messages. For 4e98da8, I couldn't easily see what this is doing without opening the code, but if functional testing shows that it closes #87 then 👍 . So this probably just needs basic functional testing.

[taldcroft]

When you think it's ready.