Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email on supplement promotion #115

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Email on supplement promotion #115

merged 1 commit into from
Jun 1, 2021

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Jun 1, 2021

Description

Added function to send email on supplement promotion, but only if something is actually promoted.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing on /proj/sot/ska3/agasc-test

@javierggt
Copy link
Contributor Author

one question here is what to do with the destination email. Right now it is hardcoded.

@javierggt javierggt merged commit 823b26e into master Jun 1, 2021
This was referenced Jul 1, 2021
@javierggt javierggt mentioned this pull request Jul 12, 2021
@jeanconn jeanconn deleted the promotion-email branch March 18, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant