Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to obs_status.yml with process help #129

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Dec 29, 2021

Description

This PR puts much of the necessary information for supplement disposition and promotion into the RC obs_status.yml file.

Testing

  • [n/a] Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Functional testing

From @javierggt:

I did the following test:

mkdir test
cd test
echo 5115672 > agasc_ids
agasc-update-magnitudes --agasc-id-file agasc_ids

and checked that the obs_status file was there and with the expected output. Then I edited the file, amended the supplement in the current directory, and checked that it was ok:

agasc-update-supplement --output-dir `pwd` --obs-status-file obs_status.yml 

@javierggt
Copy link
Contributor

Looks ok to me. Since we are adding a detailed description of steps to follow, we might as well add a link to the diff that is generated after applying the dispositions.

As a test, one can run something like what is run in the workflow, which should produce an obs_status file, and then apply that to make sure it runs ok. I can do that. I do not foresse a problem, given that all changes are in comments.

@taldcroft
Copy link
Member Author

@javierggt - I added a link to the diffs per your suggestion. If you can do some functional test that would be great!

@javierggt
Copy link
Contributor

javierggt commented Jan 3, 2022

I did the following test:

mkdir test
cd test
echo 5115672 > agasc_ids
agasc-update-magnitudes --agasc-id-file agasc_ids

and checked that the obs_status file was there and with the expected output. Then I edited the file, amended the supplement in the current directory, and checked that it was ok:

agasc-update-supplement --output-dir `pwd` --obs-status-file obs_status.yml 

@taldcroft taldcroft merged commit 36211c9 into master Jan 3, 2022
@taldcroft taldcroft deleted the obs-status-inline-help branch January 3, 2022 14:29
@javierggt javierggt mentioned this pull request Mar 30, 2022
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants