Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix breakage due to kadi 5.9.1 changing dtypes #136

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Apr 13, 2022

Description

Since kadi 5.9.1, mp_starcat_date is returned as bytestring instead of unicode string. This PR fixes that.

Interface impacts

None

Testing

Unit tests

  • Mac

Functional tests

The following code:

from agasc.supplement.magnitudes.mag_estimate import get_agasc_id_stats
get_agasc_id_stats(869141880)

fails in current master with the error KeyError: '2022:056:18:53:56.158'

It succeeds after the change in this PR.

@javierggt javierggt merged commit 5b2557e into master Apr 13, 2022
@javierggt javierggt deleted the kadi-fix branch April 14, 2022 19:23
@javierggt javierggt mentioned this pull request Apr 21, 2022
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants