Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the columns in test_update_obs are consistent #147

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Jan 30, 2023

Description

This is a relatively trivial change. In 2023.1rc4, one test fails because two tables are compared, but the columns are not in the same order.

I checked in the current release, and indeed the columns are sorted in a different order, but somehow the test was passing.

Fixes #146

Interface impacts

None

Testing

Unit tests

  • Mac

Independent check of unit tests by Jean

  • Linux

Functional tests

No functional testing.

@javierggt javierggt merged commit 4468c6a into master Feb 3, 2023
@javierggt javierggt mentioned this pull request Mar 13, 2023
@javierggt javierggt mentioned this pull request May 17, 2023
@jeanconn jeanconn deleted the issue-146 branch October 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agasc unit test fails in ska3 prime
2 participants