-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme for 1p8 #182
Conversation
Regarding "should we document here that slight changes to COLOR1 to avoid 0.7 and 1.5?" - I'm thinking that's a tiny processing detail that maybe doesn't make the final public doc for COLOR1 (which currently has)
The details about 0.7000 and 1.5000 remain true. |
Regarding the "what is alpha" question in the MAG_BAND section - I'm not clear about how those values were determined. In the old agasc 1p5 comments there is a reference about how it was used.
|
I figure we should just ignore alpha in the context of the AGASC 1.8 readme update. |
This would have been good to know. Sorry I didn’t notice. A proper catalog update would have had a calibration of the Gaia color, although I doubt that a simple scaling factor would have been enough.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Jean Connelly ***@***.***>
Sent: Tuesday, July 23, 2024 5:44:52 PM
To: sot/agasc ***@***.***>
Cc: Javier Gonzalez ***@***.***>; Author ***@***.***>
Subject: Re: [sot/agasc] Update readme for 1p8 (PR #182)
I figure we should just ignore alpha in the context of the AGASC 1.8 readme update.
—
Reply to this email directly, view it on GitHub<https://www.google.com/url?q=https://github.com/sot/agasc/pull/182%23issuecomment-2245456294&source=gmail-imap&ust=1722350693000000&usg=AOvVaw00ou6biah9RBYMvCxCrNpW>, or unsubscribe<https://www.google.com/url?q=https://github.com/notifications/unsubscribe-auth/AABCJ2ZLI2COEHYA7KKSKATZNZT6JAVCNFSM6AAAAABJ6CXCCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBVGQ2TMMRZGQ&source=gmail-imap&ust=1722350693000000&usg=AOvVaw3JNYEjqJado2NNip37rUAB>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I would say that I think the AGASC 1.8 catalog update is "proper" - you just have the code in the agasc-gaia repo showing how MAG_ACA was derived instead of these old/defunct polynomials. |
Though that kinda raises the question - should we make the agasc-gaia repo public and link to it from the README? |
I would prefer not since there is a lot of uncurated material there. |
About:
That is not precisely correct if the AGASC catalog color is now from Gaia but Tycho-2 shows B-V > 1.5 . I would suggest:
|
About the |
And I didn't see the |
Apart from my one comment, I think this is good enough. |
OK I updated the COLOR1 text per Tom and a tiny typo while I was in the neighborhood. |
Description
This PR makes minimal changes to readme (the one in github.io). I tried to leave the readme as unchanged as possible, but I actually believe it should be improved more. I think as it stands, the readme is hard to understand.
Still, these changes would bring it up to date.
questions:
MAG_BAND
description?Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.