Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of bad stars in test #188

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Reduce number of bad stars in test #188

merged 1 commit into from
Aug 21, 2024

Conversation

jeanconn
Copy link
Contributor

Description

Reduce number of bad stars in test. There are now 579 bad stars in the list, so this updates the check from > 3300 to > 300 (I left it as > 300 with the idea that more might still be removed, and as a sanity test, 300 seemed fine).

Fixes #

Interface impacts

Testing

Unit tests

  • Mac arm64
(ska3) flame:agasc jean$ git rev-parse HEAD
e169f17541ddb871ee426db9de96316a16197130
(ska3) flame:agasc jean$ pytest 
========================================================================================== test session starts ==========================================================================================
platform darwin -- Python 3.11.8, pytest-8.0.2, pluggy-1.4.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: timeout-2.2.0, anyio-4.3.0
collected 77 items                                                                                                                                                                                      

agasc/tests/test_agasc_1.py .......                                                                                                                                                               [  9%]
agasc/tests/test_agasc_2.py ..........sssss..........ss..................                                                                                                                         [ 67%]
agasc/tests/test_agasc_healpix.py ...........                                                                                                                                                     [ 81%]
agasc/tests/test_obs_status.py ..............                                                                                                                                                     [100%]

===================================================================================== 70 passed, 7 skipped in 7.96s

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from javierggt August 19, 2024 17:08
@jeanconn jeanconn merged commit 686aa3f into master Aug 21, 2024
2 checks passed
@jeanconn jeanconn deleted the fewer-bad-stars branch August 21, 2024 17:18
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants