Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests pass on Windows #42

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Make tests pass on Windows #42

merged 1 commit into from
Mar 4, 2020

Conversation

taldcroft
Copy link
Member

Description

The HOME environment variable that is used to find ~/.ascrc doesn't exist on Windows, but nor will ~/.ascrc.

BTW, the right idiom for this sort of thing is os.expanduserpath('~/.ascrc') which works on all platforms.

Testing

  • Passes unit tests on Windows (did not try linux but there is no code change, just putting one line inside the try.

@taldcroft taldcroft mentioned this pull request Mar 4, 2020
Closed
23 tasks
@taldcroft taldcroft merged commit 6e65adc into master Mar 4, 2020
@taldcroft taldcroft deleted the fix-windows branch March 4, 2020 17:42
@javierggt javierggt mentioned this pull request Apr 20, 2020
Merged
17 tasks
@javierggt javierggt mentioned this pull request May 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@taldcroft