Fix errors in reprocessing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
reviewed
Sep 1, 2022
astromon/cross_match.py
Outdated
| @@ -747,6 +747,7 @@ def simple_cross_match( | |||
| matches['dz'] = matches['x_z_angle'] - matches['c_z_angle'] | |||
| matches['dy'] = matches['x_y_angle'] - matches['c_y_angle'] | |||
| matches['dr'] = np.sqrt(matches['dy']**2 + matches['dz']**2) | |||
| matches['cat_order'] = table.Column(length=len(matches), dtype=int) | |||
There was a problem hiding this comment.
You can do with in one line with:
matches['cat_order'] = np.full(len(matches), 200)
With modern astropy the Column class constructor is almost never needed for user code.
There was a problem hiding this comment.
I adopted this suggestion.
…an empty table (instead of using the Column constructor)
taldcroft
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes small errors found in reprocessing.
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
All OBSIDs that showed errors previously were processed without error.