Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aca_view issue 57, need masked=True in Table creation #111

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

taldcroft
Copy link
Member

Description

The astropy Table class changed behavior so that a Table can hold both MaskedColumn and Column at once. The fix here is to force all MaskedColumn with masked=True.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing - fixes the problem in aca_view

Fixes https://github.com/sot/aca_view/issues/57

@taldcroft taldcroft requested a review from javierggt November 15, 2020 10:38
@javierggt javierggt merged commit 9d5b59c into master Nov 16, 2020
@javierggt javierggt mentioned this pull request Dec 7, 2020
@jeanconn jeanconn deleted the masked-table branch March 10, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants