Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed maude_decom to work on real-time #128

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Fixed maude_decom to work on real-time #128

merged 7 commits into from
Aug 24, 2022

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Aug 12, 2022

Description

This makes the following changes:

  • cast packet['IMGTYPE'] as int in _group_packets (it was a string in real-time)
  • the blobs argument to get_aca_packets was ignored. Fixed.
  • the result of get_aca_packets did not include the INTEG and END_INTEG_TIME columns if the times were not shifted to match level0 times (shifting times used to be the default in aca_view until now).

Fixes #127

Interface impacts

None

Testing

Unit tests

  • Mac

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt changed the title Blobs Fixed get_aca_packets from blobs Aug 12, 2022
@javierggt javierggt changed the title Fixed get_aca_packets from blobs Fixed maude_decom to work on real-time Aug 22, 2022
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together with Javier, looks fine.

@taldcroft taldcroft merged commit cca1c2e into master Aug 24, 2022
@taldcroft taldcroft deleted the blobs branch August 24, 2022 17:51
This was referenced Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maude_decom.get_aca_packets from blobs does not handle blobs argument and does not pad stop time
2 participants