Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in maude_decom.get_aca_packets from blobs #130

Merged
merged 2 commits into from
Sep 16, 2022
Merged

fix in maude_decom.get_aca_packets from blobs #130

merged 2 commits into from
Sep 16, 2022

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Sep 8, 2022

Description

This is a trivial change in maude_decom.

When calling get_aca_packets using blobs, it currently sets the image function from AOACFCT{slot}, which is the MSID for the image function in the OBC. After this PR, it will set it from {pea_prefix}AIMGF{slot}1.

One reason to keep the OBC value is that it is sampled much more often, but then it does not match the image shown, so this can cause confusion. I do not remember if we explicitly decided to keep that one. If wed wanted that, I still think this is not the place to do it (because this is all about ACA packets).

Another option is to not have a single image function, but include all four instances of IMGFUN found in ACA telemetry.

Interface impacts

None

Testing

Unit tests pass, including a new test that would fail in current master.

Unit tests

  • Mac

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt mentioned this pull request Sep 12, 2022
51 tasks
@taldcroft
Copy link
Member

it is sampled much more often

I presume that you mean the OBC AO.. version is sampled every 1.025 sec and the PEA version comes down once per readout image (which could be either 1.025, 2.05, or 4.1 sec). ls that right?

@taldcroft
Copy link
Member

The code looks fine, there just needs to be some documentation of testing since I presume the unit tests don't cover this.

@javierggt
Copy link
Contributor Author

I presume that you mean the OBC AO.. version is sampled every 1.025 sec and the PEA version comes down once per readout image

Yes

I added a test that fails in current master and this PR would fix it. Basically, the decom from VCDU frames takes IMGNUM1 already, and this test just checks the consistency between blobs and frames.

@javierggt javierggt requested a review from taldcroft September 14, 2022 17:44
@javierggt javierggt merged commit 1f80f39 into master Sep 16, 2022
@javierggt javierggt deleted the blobs branch September 16, 2022 00:28
This was referenced Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants