Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Ska2: add dither cmd sets, fix nsm cmd set, and update scs107 cmd set #65

Merged
merged 6 commits into from
Oct 27, 2021

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Oct 27, 2021

Description

Same as #64 but for Ska2.

Doing another backport is not ideal but we do not have any other timely choices. Getting these state updates in place is time critical to be prepared for the next safing action.

Testing

  • Passes unit tests on Ska2 linux (kady)
  • [n/a] Functional testing

Deployment

We will discuss on Slack how to appropriately deploy this.

Fixes #37

@jeanconn
Copy link
Contributor

Thanks Tom! This is great.

I'm guessing that there have been no real downstream effects with our lack of updates to support your feature request in #37

@taldcroft taldcroft changed the title Add dither cmd sets, fix nsm cmd set, and update scs107 cmd set Ska2: add dither cmd sets, fix nsm cmd set, and update scs107 cmd set Oct 27, 2021
@taldcroft
Copy link
Member Author

Good catch with #37, done. So we can actually close an issue!

@taldcroft
Copy link
Member Author

I've re-run the unit tests with the latest version of this through 35f277e.

@taldcroft taldcroft requested a review from jeanconn October 27, 2021 20:33
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this and reviewed it before these last changes (which are also great).

@taldcroft taldcroft merged commit 2f421da into ska2 Oct 27, 2021
@taldcroft taldcroft deleted the dither-cmd-sets-ska2 branch October 27, 2021 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants