Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACA acquisition probability models #100

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Add ACA acquisition probability models #100

merged 1 commit into from
Jan 25, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Jan 24, 2023

Description

This adds data files for the ACA acquisition probability model that gets used in chandra_aca.star_probs.

Testing

See sot/chandra_aca#140

Copy link

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me (as an independent PR that we can review and merge before the new model).

@matthewdahmer
Copy link
Contributor

Do we need to increment the version for this and does this change require a Jira ticket?

@jeanconn
Copy link

I would figure we would just bother to increment the version on the "other" PR that will have the update to the model.

@matthewdahmer
Copy link
Contributor

Including this PR in the upcoming release works for me as long as this PR can be merged in time with the ACA model update. If this PR affects a flight approved process upon promotion it should be accompanied by a Jira ticket though, and the ACA model is just about ready for promotion (all non FD approvals are in).

@jeanconn
Copy link

And with regard to "update to the model" I was speaking to the update to the acquisition probability model not the update to the aca thermal model. I leave it to Tom to say if he wants to get this in to the ACA thermal model update release.

@taldcroft
Copy link
Member Author

Since these new files don't yet impact any flight-approved process I think we can just merge this without additional review. Does it make life simpler if we hold off on merging until version 3.46 is approved and deployed (FSDS-62)? There is really no urgency on this one apart from making review of other Ska PR's a little easier.

@matthewdahmer
Copy link
Contributor

In that case there is no issue with merging this in at any time, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants