Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in axTime3.cc #32

Merged
merged 2 commits into from
Jan 6, 2019
Merged

Fix memory leak in axTime3.cc #32

merged 2 commits into from
Jan 6, 2019

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Jan 5, 2019

Implements fix suggested by @mbaski in #31 to fix a memory leak that has been there for at least 12 years (!).

Testing:

  • Confirmed that this fixes the memory leak on Mac using the code snippet in Memory leak in C++ code #31 and watching memory with top. Also reproduced the leak without this fix.
  • Passes unit tests on ska3-flight on Mac, HEAD CentOS-5 and HEAD CentOS-6.

FYI Chandra.Time is not building on CentOS-6. Not a problem since 5 is still the official build platform, but will need to fix eventually.

Fixes #31

@taldcroft taldcroft requested a review from mbaski January 5, 2019 03:28
Copy link

@mbaski mbaski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, the unit tests pass successfully, the thermal models work as expected in MCC, and the memory leak appears to be fixed.

@taldcroft taldcroft merged commit 5003b9e into master Jan 6, 2019
@taldcroft taldcroft deleted the memleak branch January 6, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in C++ code
2 participants