Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OOBTHR 02-07 to wide MSIDs following PR-411 #142

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Conversation

taldcroft
Copy link
Member

Testing:

Manually read in an OBA4ENG FITS file with the PR-411 uplink transition date temporarily patched to be before the data in the FITS file. Confirmed that the narrow and wide outputs were identical for OOBTHR02. Then did same with transition date set to actual transition and saw that narrow and wide outputs differed as expected.

import pyfits
from Ska.engarchive.converters import *
hdus = pyfits.open('obcf599620705N001_4_eng0.fits.gz')
dat = hdus[1].data
hdus.close()
len(dat)
ndat = numpy_converter(dat)
ondat = obc4eng(ndat)
ondat.dtype.names
ondat['OOBTHR02'] - ondat['OOBTHR02_WIDE']

With this testing I'm planning to install shortly so that processing tomorrow morning will pick up the change.

Copy link
Contributor

@matthewdahmer matthewdahmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@taldcroft taldcroft merged commit 9ff2054 into master Nov 8, 2017
@taldcroft taldcroft deleted the oba-wide branch November 8, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants