Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add a negative lookahead assertion for log check" #256

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Revert "Add a negative lookahead assertion for log check" #256

merged 1 commit into from
Feb 23, 2024

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 23, 2024 •
edited
Loading

@taldcroft taldcroft requested a review from jeanconn February 23, 2024 14:10
jeanconn
jeanconn approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@taldcroft taldcroft merged commit 199d78a into master Feb 23, 2024
2 checks passed
@taldcroft taldcroft deleted the revert-253-exclude-hdf5-retry-error-warning-from-check branch February 23, 2024 16:51
@javierggt javierggt mentioned this pull request Feb 27, 2024
Closed
This was referenced Mar 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanconn jeanconn jeanconn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taldcroft @jeanconn