Update NOTES.fix_bad_ingest.rst

[taldcroft]

Description

Update documentation for fixing an ingest problem.

Interface impacts

None

Testing

Docs only, no testing except that the commands were actually run to fix an ingest issue.

[jeanconn]

I'm not actually clear on what part of this process fixed the issue. Naively it seems like you'd need to identify and remove a bad file, but did the bad file go away upstream (CXCDS archive) so that was not necessary?

[taldcroft]

I'm not actually clear on what part of this process fixed the issue

The notes doc starts with the defining assumption:

These notes document how to fix the cheta archive if a bad CXC archive file has
been ingested and then the CXC archive is subsequently repaired.

In other words, turn it off and turn it on again by just trying to reprocess the truncated archive at a later time.

[jeanconn]

And I'm fine with ignoring the unrelated ruff issues for now.

[taldcroft]

Yeah, I looked at the ruff and didn't want to include them here.

I agree with ruff that overriding a function arg with a loop variable is a pretty bad idea, but making those changes needs to be done a little carefully (at least ensuring coverage). I can see that my coding has evolved quite a bit in 10 years, hopefully for the better. 😄