This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Add dither cmd sets and fix nsm cmd_set, etc #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought the fundamental issue was that we still want to modernize to Ska3, update testing, and avoid backports. Hence #51 has been hanging around. |
Argh. Forgot there is this whole mess of Ska2 code still going. |
taldcroft
changed the title
Add dither cmd sets and fix nsm cmd_set
Add dither cmd sets and fix nsm cmd_set: DO NOT MERGE
Oct 25, 2021
From Gregg, so we probably want to update the scs107 state.
|
1 task
Should we just merge this? |
Yes. Though not sure if it is worth cutting the ska2-compatible bits. |
taldcroft
changed the title
Add dither cmd sets and fix nsm cmd_set: DO NOT MERGE
Add dither cmd sets and fix nsm cmd_set
Nov 1, 2021
taldcroft
changed the title
Add dither cmd sets and fix nsm cmd_set
Add dither cmd sets and fix nsm cmd_set, etc
Nov 1, 2021
The Ska2 compatibility is not compromising the Ska3 testing, so it can stay. |
jeanconn
approved these changes
Nov 1, 2021
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds
dith_on
anddith_off
command sets. It also updates thensm
command set to includescs107
anddith_off
.Testing
Fixes #50