Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Add dither cmd sets and fix nsm cmd_set, etc #64

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Conversation

taldcroft
Copy link
Member

Description

This adds dith_on and dith_off command sets. It also updates the nsm command set to include scs107 and dith_off.

Testing

  • Passes unit tests on MacOS (new tests)
  • [n/a] Functional testing

Fixes #50

@taldcroft taldcroft requested a review from jeanconn October 25, 2021 13:20
@jeanconn
Copy link
Contributor

I thought the fundamental issue was that we still want to modernize to Ska3, update testing, and avoid backports. Hence #51 has been hanging around.

@taldcroft
Copy link
Member Author

Argh. Forgot there is this whole mess of Ska2 code still going.

@taldcroft taldcroft changed the title Add dither cmd sets and fix nsm cmd_set Add dither cmd sets and fix nsm cmd_set: DO NOT MERGE Oct 25, 2021
@taldcroft
Copy link
Member Author

From Gregg, so we probably want to update the scs107 state.

Recently, SCS-106 was updated to leave 3 FEPs on rather than no FEPs on.
SCS-106 is run as part of the SCS-107 sequence.

Therefore thermal model history assembly requires that this change be reflected
in any shutdown: both science-only shutdowns as well as Full Stops.  Also, the
ACIS Team recently added new power commands which have to be handled by Backstop History.

@taldcroft
Copy link
Member Author

Should we just merge this?

@jeanconn
Copy link
Contributor

jeanconn commented Nov 1, 2021

Yes. Though not sure if it is worth cutting the ska2-compatible bits.

@taldcroft taldcroft changed the title Add dither cmd sets and fix nsm cmd_set: DO NOT MERGE Add dither cmd sets and fix nsm cmd_set Nov 1, 2021
@taldcroft taldcroft changed the title Add dither cmd sets and fix nsm cmd_set Add dither cmd sets and fix nsm cmd_set, etc Nov 1, 2021
@taldcroft
Copy link
Member Author

The Ska2 compatibility is not compromising the Ska3 testing, so it can stay.

@taldcroft taldcroft merged commit 987ca48 into master Nov 1, 2021
@taldcroft taldcroft deleted the dither-cmd-sets branch November 1, 2021 13:44
@jeanconn jeanconn mentioned this pull request Dec 3, 2021
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a dither disable to the nsm command set
2 participants