Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace uses of pformat_all with pformat #48

Merged
merged 1 commit into from
Jan 6, 2025
Merged

replace uses of pformat_all with pformat #48

merged 1 commit into from
Jan 6, 2025

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Jan 4, 2025

Description

This is a change intended for skare3 > 2025.0, where we will use astropy 7.0. It replaces uses of Table.pformat_all() wih Table.pformat(). This silences a warning.

Requirements

Astropy >= 7.0.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-2025.0rc5) ~/SAO/git/cxotime pformat $ pytest cxotime
============================================================= test session starts =============================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/javierg/SAO/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 250 items                                                                                                                           

cxotime/tests/test_cxotime.py ......................................................................................................... [ 42%]
..................................................................................................................................      [ 94%]
cxotime/tests/test_cxotime_linspace.py ...............                                                                                  [100%]

============================================================= 250 passed in 1.57s =============================================================
(ska3-flight-2025.0rc5) ~/SAO/git/cxotime pformat $ git rev-parse --short HEAD                            
d55fa2e

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt merged commit 811f123 into master Jan 6, 2025
2 checks passed
@javierggt javierggt deleted the pformat branch January 6, 2025 18:13
This was referenced Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants