Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more workflows to this project #51

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Add more workflows to this project #51

merged 6 commits into from
Nov 2, 2021

Conversation

jeanconn
Copy link
Contributor

Add more workflows to this project (release, flake8) and add a pull request template.

@jeanconn jeanconn requested a review from javierggt October 21, 2021 15:22
@jeanconn
Copy link
Contributor Author

Oops. I ran flake8 on chunks of this but apparently missed a few pieces.

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check release.yml, but otherwise looks good with comments.

.github/workflows/flake8.yml Outdated Show resolved Hide resolved
@@ -1,11 +1,10 @@
import sys
import os
import time
import pytest

sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what was driving this setting of the path, but it isn't necessary (and hence the subsequent # noqa as well). I tested taking it out and printing the jobwatch path and it is the right one and tests pass.

Co-authored-by: Tom Aldcroft <taldcroft@gmail.com>
@jeanconn jeanconn merged commit 935313c into master Nov 2, 2021
@jeanconn jeanconn deleted the more-workflows branch November 2, 2021 12:00
@jeanconn jeanconn mentioned this pull request Dec 3, 2021
@javierggt javierggt mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants