Fix bug in command-not-run command set and test #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierggt
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
The changes are simple enough, and I verified that the test introduced in this PR (kadi/commands/tests/test_commands.py::test_get_cmds_from_event_all) fails with the previous version of command_sets.py, so this PR indeed fixes the bug being tested for.
All 167 unit tests also passed
|
Late to party but I did the same review and came to the same conclusion (good to go). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a problem with the
Command not runcommand set that was missed in testing. It had previously worked when thecmds2.h5was generated, but a subsequent change broke it, but this was not seen until I regenerated the commands now.This PR fixes the problem and adds complete testing of all the allowed command sets.
Note: in order for tests to pass this is based off of #221 and the merge request is into that branch.
Interface impacts
None.
Testing
Unit tests
Independent check of unit tests by Javier
Functional tests
No functional testing.