Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dither disable from bright star hold command set #246

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Aug 17, 2022

Description

The Bright Star Hold command set mistakenly contained the command to disable dither. This command does not actually happen in BSH so this PR removes the command.

Interface impacts

None.

Testing

Unit tests

  • Mac

Independent check of unit tests by Jean

  • Linux

Functional tests

I confirmed using visual inspection with aca_view that dither is still enabled for the 2017:090 and 2022:223 BSH events.

@taldcroft taldcroft requested a review from jeanconn August 17, 2022 16:17
@taldcroft taldcroft merged commit 0e19738 into master Aug 17, 2022
@taldcroft taldcroft deleted the remove-bsh-dither branch September 14, 2022 18:33
This was referenced Oct 5, 2022
@taldcroft taldcroft added this to the 0.1 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants