Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress v1 FutureWarning for testing #255

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Suppress v1 FutureWarning for testing #255

merged 2 commits into from
Oct 4, 2022

Conversation

taldcroft
Copy link
Member

Description

For testing it is still allowed to import and use commands v1.

Interface impacts

None

Testing

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Using this branch with v7.0 version of the cmds2.* files passes pytest unit tests and does not issue any warning messages at the end.

If I change the message=... to something that does not match then I confirm the warnings are flagged by pytest.

@taldcroft taldcroft requested a review from javierggt October 3, 2022 20:08
Copy link
Contributor

@javierggt javierggt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't have removed the line from pytest.ini, but that is a detail.

@taldcroft taldcroft merged commit eea6bb1 into master Oct 4, 2022
@taldcroft taldcroft deleted the v1-testing branch October 4, 2022 15:04
@taldcroft
Copy link
Member Author

taldcroft commented Oct 4, 2022

I wouldn't have removed the line from pytest.ini, but that is a detail.

Since command-line pytest is my usual way of testing, I would like to know right away if that warning might show up later in ska_testr which doesn't respect pytest.ini rules.

This was referenced Oct 4, 2022
@javierggt javierggt mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants