Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HRC states: 15v on, HRC-I on, HRC-S on #257

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Add HRC states: 15v on, HRC-I on, HRC-S on #257

merged 3 commits into from
Oct 18, 2022

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Oct 18, 2022

Description

In support of HRC operations and load review checking (in particular acisops/acis_thermal_check#54), this adds three new HRC commanded state variables: hrc_15v, hrc_i and hrc_s. All three have state values of OFF or ON.

I regenerated the list of available commanded states in the documentation and found a few previously-added states that were not reflected in the docs.

A bug in the testing code was also discovered and fixed, namely that the fixture for temporarily setting the effective processing stop date was not clearing the commands cache at the end. This meant that subsequent tests were running with a truncated commands archive.

Finally, this PR cleans up a bunch of flake8 warnings related to line length.

Interface impacts

None.

Testing

Unit tests

  • Mac

Functional tests

@jzuhone
Copy link
Collaborator

jzuhone commented Oct 18, 2022

@taldcroft I can't click the checkbox above, but I tested this with acis_thermal_check and it works.

@taldcroft taldcroft merged commit 81ff21b into master Oct 18, 2022
@taldcroft taldcroft deleted the hrc-states branch October 18, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants