Remove a testing workaround #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the flight archive has been regenerated, am I correctly understanding that this "Fix" and its removal is a no-op? Because there are no commands to remove it isn't removing them, right? |
|
So in conversation, the commands that were "removed" by this fix were appropriate/correct but only existed in "local" not "flight" so the test would fail until regenerating the archive. Now the test fix can be removed and these commands can be checked instead of ignored. |
jeanconn
approved these changes
Jan 25, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a clean-up item.
Interface impacts
None
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.