Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue always logging about NSM during maneuver #277

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 17, 2023

Description

Fix the problem in #276 by adding a keyword arg to the debug function to specify the logging level. In most cases a warning is appropriate (the default) but this particular situation is just informational.

Fixes #276

Interface impacts

Testing

Unit tests

  • Mac (ska3-prime)

Independent check of unit tests by Jean

  • There is a test fail on linux / fido on test_commands_create_archive_regress using ska3-prime. This appears unrelated so I'm opening a separate issue.

Functional tests

Before the patch this code would generate the informational output shown in #276 (circa 2023:048):

cmds = get_cmds(CxoTime.now())

After the patch this runs quietly. I also confirmed that with the patch if the kadi.logger is set to "INFO" log level then the expected INFO output appears.

@taldcroft taldcroft requested a review from jeanconn February 17, 2023 14:16
@taldcroft
Copy link
Member Author

Ping @jeanconn. It would be good to get this into ska3-prime as it causes noise in cron jobs.

@jeanconn
Copy link
Contributor

jeanconn commented Mar 2, 2023

On this, sorry, I got side-tracked by what looks like an unrelated test fail when running on linux

FAILED kadi/commands/tests/test_commands.py::test_commands_create_archive_regress[2] - AssertionError: assert False

I couldn't remember what the state was of the archive regress (do we need new data installed on head?).

@taldcroft taldcroft merged commit ad3bba0 into master Mar 6, 2023
@taldcroft taldcroft deleted the fix-log-context-obs branch March 6, 2023 17:04
This was referenced Mar 13, 2023
@javierggt javierggt mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State debug printing to console / logging?
2 participants