Fix task schedule alert email address #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
I also note that with this change somewhat untested, the worst thing that can happen is that it doesn't work -- and it already wasn't working (I've forgotten the failure mode here but I assume it was trying to send an email to aca_alert@head.cfa.harvard.edu and one to head@cfa.harvard.edu or the like).
|
The initial failure mode is sending to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a mistake in the email address in the task schedule specification by escaping the
@cfa. This follows the example here: sot/fss_check@c674bf3.Testing
None for this change, but the mailing process is the same code as in
fss_checkand this has successfully sent an alert email in production.