Improve monitor window IR fraction plot and refactor key data structure #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
changed the title
|
@jeanconn - I think this is pretty good to go and we should get the Kalman watch tool going again. I made a mistake in not making a clean bug-fix patch, but probably the best course now is just to get this merged and installed. |
|
Right, I'm not completely clear on what level of code review to apply to trending codes with outputs just used for by-eye review. For this, it probably would have been cleanest to make the 2024:152 - 2024:196 plot to show a clean before and after on the the last one that was up. But given that the code is currently broken and your testing shows that this new code seems to work, I'm good with it. |
jeanconn
approved these changes
Jul 24, 2024
|
Thanks @jeanconn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the monitor window ionizing radiation fraction plot:
In addition the
KalmanDropsDataclass was changed so that it contains data for a single perigee. Previously it included all the data from all perigees, which was confusing and inconvenient.This also includes #15.
Functional testing
Side note
The outlier point from 178:1030 + 85 min turns out to be a high-background event. It might be useful to have the high-background event detection code available to use here.