-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show stk model #16
Merged
Merged
Show stk model #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierggt
force-pushed
the
show-stk-model
branch
from
August 6, 2024 20:11
57b9a11
to
23b1197
Compare
javierggt
force-pushed
the
show-stk-model
branch
from
August 6, 2024 22:44
23b1197
to
3cc2668
Compare
Closed
* moved data-related functions around * add options and paths modules * add --rad-data command-line option * using the same IR model numbers as in the notebook * remove unnecessary import * handle the case where there is not monitoring windows * bugfix * add some stdout to low_kalman_mon for a typical error when debugging * in kalman_watch_monitor_win_perigee, set default output name using start/stop and allow saving to png * remove spurious f * changes to figure style * fix in kalman_watch_data cache: create directory including parents if it does not exist * add to gitignore * use a mon_win_kalman_drops_-45d_-1d.html as default in-file in low_kalman_mon.py, and fix docstring in monitor_win_perigee.py * use default in/out filename in task schedule * use in-file from command line options in low_kalman_mon.py * increase height of perigee kalman plot * renamed options.OPTIONS -> config.conf * rename rootname in kalman_watch.config.ConfigNamespace * fix some pylance warnings * stop using astropy config * fixup * removed duplicated code related to get_kalman_drops_npnt: - added n_cache to config - renamed EventPerigee.get_kalman_drops_npnt as a property called kalman_drops_npnt, - renamed get_kalman_drops_nman as a property called kalman_drops_nman, - fixed wrong property caching for predicted_kalman_drops - remove duplicated code in _get_kalman_drops_nman - refactor get_kalman_drops_nman so it has the same signature as get_kalman_drops_npnt - removed _get_binned_drops_from_npnt and use get_binned_drops_from_npnt instead, * set argparse defaults from config * ruff * rename radiation data file
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to display the radiation model from STK in Kalman watch.
In order to add kalman drops data to the perigee detail page (in
kalman_perigee_mon
), the following attributes are added to theEventPerigee
class:kalman_drops_nman
kalman_drops_npnt
predicted_kalman_drops
Also:
_reshape_to_n_sample_2d
plot_kalman_drops
function was removed. This function is referenced from several docstrings, so the docstrings still need to be fixed.Note:
Some changes were done on a separate PR (#18) and marged into this branch before merging this PR:
SKA/data/stk
.kalman_perigee_mon.EventPerigee.get_kalman_drops_nman
function requires some parameters that would need to be passed all the way from the command line options to the called code inmonitor_win_perigee.py
. A config class was added to deal with this.kalman_perigee_mon.py
andmonitor_win_perigee.py
produce plots/html, and both have functions to fetch data. To modify the perigee detail page, I noticed there would be a dependence cycle between the two. I copied or moved some of the functions to make things work.Interface impacts
Changes the plot that appears in SSAWG trending summary, so the scraping code needs to be changed.
This PR requires the following Ska data:
$SKA/data/stk/radiation_data.fits
Testing
see below
Unit tests
Functional tests
Tests were done on PR #18, which was daisy-chained to this one. The squash-and-merge discarded that PR, so the testing is copied below:
Scripts were run in three different ways:
kalman_watch_monitor_win_perigee
to produce a png of the monitoring window plot:weekly.2024-09-08_0015
snapshot of the kalman_watch3 data (found indata/mta4
) into my data directory and ran: