Remove dark model #214
Merged
Remove dark model #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
force-pushed
the
remove-dark-model
branch
from
104746f to
0f1ab35
Compare
jeanconn
reviewed
Feb 14, 2020
| @@ -3,4 +3,4 @@ | |||
| doc/_build | |||
| *.pyc | |||
| *~ | |||
|
|
|||
| *.egg-info | |||
There was a problem hiding this comment.
I rebased this to clear the .gitignore conflict. Still seems fine to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
dark_modelmodule which has been deprecated for a while. There are no instances of dark_model coming from mica in thesotorg.This is causing warnings now in pytest every time
mica.archive.aca_darkgets imported.API impact
Any code now importing dark modeling functions from
mica.archive.aca_darkwill now break.Testing