Mag stats #219
Mag stats #219
Conversation
| # Set all columns with mag info to 99.0 initial value instead of zero | ||
| for col in table.dtype.names: | ||
| if 'aoacmag' in col: | ||
| table[col] = 99.0 |
There was a problem hiding this comment.
I think this is somewhat reasonable to "initialize" the numpy table with values of 99 for all the aoacmag_* cols if we want 99.0 for that kind of missing data. Not sure if other columns should get that treatment too.
There was a problem hiding this comment.
This is probably the only controversial thing in here. As with everything, hard to know how much to rummage around and improve things and how much to just back away slowly.
| @@ -112,7 +115,7 @@ | |||
| ('var', 'int'), | |||
| ('pos_err', 'int'), | |||
| ('mag_aca', 'float'), | |||
| ('mag_err', 'int'), | |||
| ('mag_aca_err', 'int'), | |||
There was a problem hiding this comment.
Hi @taldcroft and @javierggt ! It sounds like you also want a change in this PR somewhere to scale the mag_aca_err column to units of mag. That's fine. Though should that be in mica or in agasc.get_star (or get_stars) with a calibrate flag or some such?
There was a problem hiding this comment.
Well given that all the rest of this is uncalibrated it appears we cannot make a change here without having a one-off inconsistency. Just leave it. And don't bother with making an agasc issue. If one of us gets annoyed enough one day we'll do it, but it is a low priority and we don't need more low priority issues.
There was a problem hiding this comment.
Would it be less inconsistent to just UPPER CASE these?
There was a problem hiding this comment.
It would be more consistent to upper case them, but would break all existing code that uses these. Not worth the trouble I'd say.
Description
Add 5, 16, 50, 84, 95 mag stats to the guide stats table. This also adds some changes to support running on time ranges to make it easier to do trivial multiprocessing.
Testing
Fixes #216