Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More centroid_dashboard tweaks #249

Merged
merged 13 commits into from
Nov 16, 2020
Merged

More centroid_dashboard tweaks #249

merged 13 commits into from
Nov 16, 2020

Conversation

jeanconn
Copy link
Contributor

Description

A collection of fiddly little commits to: reduce extra processing, reduce skips or error-out observations, update page html to avoid reflows.

Testing

  • Passes unit tests on linux
  • Functional testing

For functional testing, have just run a bunch of year 2020 with centroid dashboard code. It is still filling in

https://icxc.cfa.harvard.edu/aspect/centroid_reports

Fixes #

@jeanconn jeanconn requested a review from taldcroft November 12, 2020 14:35
@jeanconn
Copy link
Contributor Author

This isn't needed for shiny, I just had it lingering.

@taldcroft
Copy link
Member

Excellent! One small request while you are at it is to change the y-axis label on the delta roll plot from dr (arcsec) to Roll error (arcsec) or (if that doesn't fit) Roll err (arcsec). dr is ambiguous.

@taldcroft
Copy link
Member

Another feature request - CCD temperature. This could be put in the Roll error plot window as a right-side axis.

@taldcroft
Copy link
Member

In the Performance details page, can you change Ending roll error to be "Not available" for ER's instead of 0.0? Not a huge deal but the 0.0 is wrong.

@taldcroft
Copy link
Member

Can you put the Catalog and Visualization box on the right side in a 3rd column? This would optimize for modern wide screens and let me see nearly the entire page at once when flipping through.

@jeanconn
Copy link
Contributor Author

I'm going to merge this and take those little RFEs and do them in a new PR. Thanks @taldcroft !

@jeanconn jeanconn merged commit bc482a3 into master Nov 16, 2020
@jeanconn jeanconn deleted the more_centroid branch November 16, 2020 18:05
@javierggt javierggt mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants