Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small V&V and report updates #254

Merged
merged 8 commits into from
Jan 4, 2021
Merged

A few small V&V and report updates #254

merged 8 commits into from
Jan 4, 2021

Conversation

jeanconn
Copy link
Contributor

@jeanconn jeanconn commented Jan 4, 2021

Description

A few small V&V and mica.report updates.

This:

  1. Updates the stored/saved version of the V&V entries made with the new code
  2. Has a tiny fix to remove previous records in the V&V h5 table for a run if there were different numbers of slots saved (very unusual but should not stop processing)
  3. Removes shelve support that was never really used
  4. Adds a tiny fix to only add needed columns if "mocking up" a fidprop entry to do fid V&V on a fid that has been dropped from processing.
  5. Is more rigorous opening and closing the V&V processing database as updates are done.
  6. Updates version of report and fixes link to current centroid dashboard outputs

Testing

  • Passes unit tests on Linux
  • Functional testing

With regard to functional testing, given how these data are used and given that we store the version information, I moved to running this code in the "flight" mica archive.

@taldcroft taldcroft merged commit 48bce07 into master Jan 4, 2021
@taldcroft taldcroft deleted the more_vv_fixes branch January 4, 2021 16:34
@javierggt javierggt mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants