Skip report vv warn if no sybase passwd file for db #256
Conversation
|
More klunky compromise here, but I think this keeps me happy about test coverage and could stop the warns (though now @javierggt would need to delete his passwd file if it isn't actually working for test to pass... and put it back when it works). |
| @@ -9,16 +9,21 @@ | |||
|
|
|||
| from .. import report | |||
|
|
|||
| user = os.environ.get('USER') or os.environ.get('LOGNAME') | |||
There was a problem hiding this comment.
I think the best way to get user information is this, which you can reliably use on any system:
import getpass
getpass.getuser()
| HAS_SYBASE_ACCESS = False | ||
|
|
||
| # If the user should have access, warn about the issue. | ||
| if (on_head_network() and not has_sybase() and | ||
| os.path.exists(os.path.join(os.environ['SKA'], 'data', 'aspect_authorization', |
There was a problem hiding this comment.
You should just start using Path at every opportunity. It is very much nicer in almost every case:
Path(os.environ['SKA'], 'data', 'aspect_authorization', f'sqlsao-axafvv-{user}').exists().
|
Sure. Yes, I was just extending what was there (at least in my mind) instead of doing it a little better. I can do it a little better. |
|
@javierggt up to you if you want to leave your sqlsao-axafvv-* file around or if you want to delete so the tests will pass against master until vv access actually works. |
Description
Skip report vv warn if no sybase passwd file for db
Testing
Fixes #