Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FITS unit warning #281

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Fix FITS unit warning #281

merged 1 commit into from
Feb 3, 2023

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Feb 1, 2023

Description

Fixes the FITS unit warning

Fixes #280

Interface impacts

Testing

Unit tests

  • Linux

No FITS unit warning (but plenty of others).

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

Copy link
Contributor

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "unit_parse_strict="silent"" change seems fine.

@taldcroft taldcroft merged commit 04d0340 into master Feb 3, 2023
@taldcroft taldcroft deleted the fix-fits-unit-warning branch February 3, 2023 21:44
@javierggt javierggt mentioned this pull request Mar 13, 2023
@javierggt javierggt mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astropy UnitsWarning (not supported by the FITS standard)
2 participants