Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent matplotlib warning #371

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Prevent matplotlib warning #371

merged 2 commits into from
Jan 27, 2022

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Jan 20, 2022

Description

This PR prevents this warning that appeared int sot/skare3/pull/755

FixedFormatter should only be used together with FixedLocator

Maybe there is a better way?

Testing

  • Passes unit tests on MacOS (no warnings emitted)
  • Functional testing

Functional testing

TA ran star selection for obsid 8008 using this PR and visually inspected the acq report and noticed no problems with the imposter plots (and all plots in general). Also did a side-by-side comparison with the same output from current master and saw no diffs.

Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did functional testing and ran unit tests (documented in the description) and it looks good. I'm not enough of a matplotlib expert to suggest a better way but this looks good to me.

@javierggt javierggt merged commit 385d26e into master Jan 27, 2022
@javierggt javierggt mentioned this pull request Feb 8, 2022
3 tasks
@javierggt javierggt mentioned this pull request Aug 3, 2022
@javierggt javierggt deleted the plot-style-warning branch January 5, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants